#772 Fixed ObjectManagerDecoratorTest, which wasn't considering void hints
#773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@ondrejmirtes shit happens, no need to be sorry :-) |
Ocramius
suggested changes
Feb 4, 2017
| public function testAllMethodCallsAreDelegatedToTheWrappedInstance($method, array $parameters, $isVoidMethod) | ||
| { | ||
| $returnedValue = $isVoidMethod ? 'INNER VALUE FROM ' . $method : null; | ||
| $returnedValue = !$isVoidMethod ? 'INNER VALUE FROM ' . $method : null; |
Member
There was a problem hiding this comment.
Please just invert the ternary - adding a boolean negation just makes it more confusing
ondrejmirtes
force-pushed
the
fix-test
branch
from
8d23e85 to
924f5f3
Compare
Member
|
👍 |
Member
|
Linking #722 |
Ocramius
changed the title
ObjectManagerDecoratorTest, which wasn't considering void hints
Ocramius
changed the title
ObjectManagerDecoratorTest, which wasn't considering void hintsObjectManagerDecoratorTest, which wasn't considering void hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the mistake, I didn't notice that the test does not run :/