Address deprecations from doctrine/persistence #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
address-persistence-deprecations
branch
from
65945b5 to
0c112bb
Compare
alcaeus
requested changes
Dec 19, 2019
Member
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
This needs to bump the doctrine/persistence dependency to ^1.3.3 as 1.2.x does not have the forward compatibility layer.
The "Common" portion of the namespace has been removed following a split of doctrine/common into several packages.
greg0ire
force-pushed
the
address-persistence-deprecations
branch
from
0c112bb to
90cbf94
Compare
Member
Author
|
I feel stupid, I updated the lock file but not the json manifest 🤦♂️ I just pushed with that change. |
alcaeus
approved these changes
Dec 20, 2019
Member
|
Note: I'd like to hold off on merging this as we've seen build failures downstream after merging down changes in doctrine/persistence. I'd like to avoid this over the holidays to give people time to unwind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Commonportion of the namespace has been removed following a splitof
doctrine/commoninto several packages.