improved error handling for invalid association values

[flip111]

Possibly to do:

1. Make custom Exception for line 713
2. Make custom Exception for line 817
3. Does the object check on line 816 slow down the code too much? Alternatively a try-catch could be put around line 1415 or higher up.

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3098

We use Jira to track the state of pull requests and the versions they got
included in.

[stof]

IMO, the var_export should be removed from the exception message. IT could make it pretty unreadable

and yes, you should not use the base exception class. Use the ORMInvalidArgumentException here

[flip111]

@stof i considered invalidObject::invalidObject exception, just that this one talks about a parameter, but this is about a property. That made me doubt if ORMInvalidArgumentException is the right class to put this as it's not clear to me if the ArgumentException is about the internal Doctrine arguments or the programmer argument. In case ORMInvalidArgumentException a new method should be created imo.

Do you have a good alternative to var_export? i could only use gettype (like the invalidObject method), but showing the actual value might be more expressive?

Edit:
Stof, are you suggesting to use ORMInvalidArgumentException for both line 713 and 817? The exception on line 817 needs to have a value attached so might be better to use a different class all together.

[Ocramius]

You shouldn't catch generic exceptions here.

[Ocramius]

Closing as incomplete.