findByXXX does not accept orderBy/limit/offset#115
Conversation
Member
|
Idea seems very great, but your code needs some polish. @beberlei could you please look into this one? |
Member
|
I created an issue for this one: http://www.doctrine-project.org/jira/browse/DDC-1426 |
Contributor
Author
|
thx, (w/o looking at the code) a better solution for the if-cascade might be always calling the 4 param method and pass dummy params (null/array()) to indicate missing arguments of findByXXX |
Member
|
If we introduce this new functionality, there should also be tests for it. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our modification to pass
findByXXXfunctionsorderBy/limit/offsetparams for entity repositories like one is used from normal findBy function.We're using an if cascade in favor of the
call_user_function_arraysince the latter is considered as slow.PS: If i need to target this pull request to your master, I'll resubmit - it's just that we're building against a stable codebase.