Skip to content

annotation type validation#117

Closed
FabioBatSilva wants to merge 3 commits intodoctrine:masterfrom
FabioBatSilva:annot-type
Closed

annotation type validation#117
FabioBatSilva wants to merge 3 commits intodoctrine:masterfrom
FabioBatSilva:annot-type

Conversation

@FabioBatSilva
Copy link
Member

Hello all,

This patch adds the validation types for annotations mapping, that is now supported by the common 2.2.
We have a small incompatibility with tests caused by changes in the common cache.

I'm not familiar with cache package. So I had to use markTestSkipped
Maybe someone can help me with cache tests(QueryCacheTest.php, ResultCacheTest.php)

This feature depends of update to 2.2 common
I think it's a good idea use common 2.2 as default

Thanks ...

Best Regards,
Fabio B. SIlva

@schmittjoh
Copy link
Member

There have been several changes with regards to caching and the tests may not have been updated yet. I'd suggest to leave these tests out for now, @guilhermeblanco knows probably how to fix them best.

@FabioBatSilva
Copy link
Member Author

Hello Johannes,

After a conversation with @guilhermeblanco he suggested temporary use of markTestSkipped,
he will fix this before merge this PR

Thank you Johannes and Guilherme

@stof
Copy link
Member

stof commented Sep 4, 2011

markTestIncomplete could be more appropriate as skipping the test is done because the test need to be changed, not because it cannot be run on your setup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see why you use an empty abstract class. If you need a marker, use an interface

@FabioBatSilva
Copy link
Member Author

Hello @stof,

All changes done

Thanks ...

@guilhermeblanco
Copy link
Member

Hi all,

Since this patch required extra work, I cherry-picked it and finished the implementation.
Everything is working now with latest code from Common and DBAL.

Cheers,

beberlei added a commit that referenced this pull request Jan 23, 2013
…ingAnnotations

[DDC-1872] add tutorial for override annotations mappings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants