Merged
Conversation
lib/Doctrine/ORM/Configuration.php
Outdated
Member
There was a problem hiding this comment.
It has to derive from Doctrine\ORM\EntityRepository
Member
|
Except the little note i like this patch, thanks for contributing! |
lib/Doctrine/ORM/ORMException.php
Outdated
Member
There was a problem hiding this comment.
the curly brace should be on its own line
Member
Author
|
Hello, All changes done Thanks ... |
guilhermeblanco
added a commit
that referenced
this pull request
Sep 8, 2011
beberlei
added a commit
that referenced
this pull request
Jan 23, 2013
Remove "before the lists of scheduled changes are cleared"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello all,
This patch is based on: DDC-753
http://www.doctrine-project.org/jira/browse/DDC-753
This patch is very similar to DDC-869
adds support for register a global custom repository class
Any classes would use that custom repository class, optionally overriding it using some maping (xml,php,annot)..
I need a suggestion on whether I should throw exceptions when the repository does not implement ObjectRepository.
I'm doing this in Configuration#setDefaultRepositoryClassName, may also be necessary in ClassMetadataInfo#setCustomRepositoryClass
What do you think about it?
Thanks ...
Best Regards,
Fabio B. SIlva