Fix an insertion of a collection to collectionUpdates/collectionDeletions properties#132
Closed
realmfoo wants to merge 1 commit intodoctrine:masterfrom
realmfoo:fix
Closed
Fix an insertion of a collection to collectionUpdates/collectionDeletions properties#132realmfoo wants to merge 1 commit intodoctrine:masterfrom realmfoo:fix
realmfoo wants to merge 1 commit intodoctrine:masterfrom
realmfoo:fix
Conversation
Member
|
I suppose this fixes http://www.doctrine-project.org/jira/browse/DDC-1210 ? |
Author
|
Yes |
Member
|
Patch seems ok to me. @beberlei, any final input? I'll merge if you don't mind. =) |
Member
|
Even if i closed the issue as invalid, this is still a valid refactoring. |
Member
|
@beberlei why closing the PR if it is valid ? |
|
I got the same problem. This fixes the problem. Why don't you merge it? |
|
Same issue here, any news ? |
|
This bug has been fixed with the last commit in branch 2.1.x : 1c0f88f Maybe a 2.1.8 tag should be created ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method computeAssociationChanges doesn't use spl_object_hash to add collection only once to array. It can lead to an exception if computeChangeSets would be called twice.
Exactly changes were already made to entityChangeSets, entityUpdates and etc.