Skip to content

Ddc 1385#152

Closed
ehabinl wants to merge 6 commits intodoctrine:masterfrom
ehabinl:DDC-1385
Closed

Ddc 1385#152
ehabinl wants to merge 6 commits intodoctrine:masterfrom
ehabinl:DDC-1385

Conversation

@ehabinl
Copy link

@ehabinl ehabinl commented Oct 16, 2011

I added a new feature for cache grouping, so please can you merge to the master branch

@stof
Copy link
Member

stof commented Oct 16, 2011

Why are you including @beberlei's commits in your branch ? They are part of a WIP branch (see #151) so I don't see why you should request a merge into master for them

@stof
Copy link
Member

stof commented Oct 16, 2011

Other point: your commit does not follow the Doctrine coding standards

@stof
Copy link
Member

stof commented Oct 16, 2011

btw, I don't see what is the relation between your change and DDC-1385

@ehabinl
Copy link
Author

ehabinl commented Oct 16, 2011

mmmm. I am sorry, This is my first time contributing with doctrine, but I am trying :)

@ehabinl
Copy link
Author

ehabinl commented Oct 16, 2011

I only change one file "lib/Doctrine/ORM/AbstractQuery.php"
so I think I did something wrong :(

@stof
Copy link
Member

stof commented Oct 16, 2011

It seems like you created your branch based on the WIP branch instead of the master branch.

Regarding coding standards, you need to use 4 spaces per level, not tabs.

@beberlei
Copy link
Member

You can try to start over by doing the following in your terminal:

git checkout master
git checkout -bQueryCacheTags
git cherry-pick a316c63     
git cherry-pick b2921c6
git push origin QueryCacheTags

@ehabinl
Copy link
Author

ehabinl commented Oct 18, 2011

Thanks Beberlei, I did that :)

@beberlei
Copy link
Member

Closing this.

@beberlei beberlei closed this Oct 31, 2011
beberlei added a commit that referenced this pull request Jan 23, 2013
Documented `guid` mapping type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants