Closed
Conversation
… top-level indexes, not some weird result. This is a BC break to those that actually use this crazy logic, sorry for that :-)
… s into a group, so that we can do a bulk cache flushing
Member
Member
|
Other point: your commit does not follow the Doctrine coding standards |
Member
|
btw, I don't see what is the relation between your change and DDC-1385 |
Author
|
mmmm. I am sorry, This is my first time contributing with doctrine, but I am trying :) |
Author
|
I only change one file "lib/Doctrine/ORM/AbstractQuery.php" |
Member
|
It seems like you created your branch based on the WIP branch instead of the master branch. Regarding coding standards, you need to use 4 spaces per level, not tabs. |
Member
|
You can try to start over by doing the following in your terminal: |
Author
|
Thanks Beberlei, I did that :) |
Member
|
Closing this. |
beberlei
added a commit
that referenced
this pull request
Jan 23, 2013
Documented `guid` mapping type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new feature for cache grouping, so please can you merge to the master branch