Update lib/Doctrine/ORM/Query/AST/SimpleSelectExpression.php#164
Closed
asm89 wants to merge 1 commit intodoctrine:masterfrom
Closed
Update lib/Doctrine/ORM/Query/AST/SimpleSelectExpression.php#164asm89 wants to merge 1 commit intodoctrine:masterfrom
asm89 wants to merge 1 commit intodoctrine:masterfrom
Conversation
Member
|
@guilhermeblanco your take |
Member
|
As discussed in IRC, this patch is wrong, because we can never have a hidden field in a subquery. It seems it was a lib problem, not Doctrine's. |
Member
Author
|
@beberlei Talked with @guilhermeblanco and he doesn't like it, so i'll close it and send a PR to your extensions repository to update the failing code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A public property $hiddenAliasResultVariable was added to
SelectExpressionin ebe9338. It should also be added to SimpleSelectExpression to allow for more advanced custom query walking like here:https://github.com/beberlei/DoctrineExtensions/blob/master/lib/DoctrineExtensions/Paginate/LimitSubqueryWalker.php#L71
Right now the missing property is causing a crash when using the Paginate extension of beberlei.