Skip to content

association override#218

Closed
FabioBatSilva wants to merge 9 commits intodoctrine:masterfrom
FabioBatSilva:DDC-964-AssociationOverride
Closed

association override#218
FabioBatSilva wants to merge 9 commits intodoctrine:masterfrom
FabioBatSilva:DDC-964-AssociationOverride

Conversation

@FabioBatSilva
Copy link
Member

Hello All

This patch is one part of DDC-964 : http://www.doctrine-project.org/jira/browse/DDC-964
First part add suport for AssociationOverride.

I wrote this code based on java implementation :
http://docs.oracle.com/javaee/6/api/javax/persistence/AssociationOverride.html

Any sugestion are welcome

Thanks

@guilhermeblanco
Copy link
Member

The idea is awesome, but the patch can't be evaluated quickly.
There're thousands of possibilities and we can't merge blindly and open a can of worms.

I'll be evaluating the patch, but it takes time. I also wonder if @beberlei and @asm89 want to evaluate too.

@beberlei
Copy link
Member

It looks very good, but its missing XML and YAML Driver support :-)

@FabioBatSilva
Copy link
Member Author

hello

I changed many things to implement the other drivers.
Please take a look again. //cc @guilhermeblanco, @beberlei

@michelsalib
Copy link

Can't wait to see it merged. Any news ? //cc @guilhermeblanco, @beberlei

@FabioBatSilva
Copy link
Member Author

ping :)

@asm89
Copy link
Member

asm89 commented Mar 11, 2012

Nice PR! I'll try to sit down and thoroughly go through the code this week. On a quick scroll it looks nice.

@guilhermeblanco @beberlei Checked it out after the added commits?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should keep tje leading \

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done !!

@FabioBatSilva
Copy link
Member Author

Hi :)

Any news about this one ?

@FabioBatSilva
Copy link
Member Author

i'm opening a new PR for this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants