When using a ManyToMany relationship no listener is notified about any change to the owning entity#256
Merged
beberlei merged 2 commits intodoctrine:masterfrom Mar 3, 2012
Conversation
…y change to the owning entity. What I'm doing with this patch is marking the entity for update when there is a modification in the ManyToMany relationship so the listeners are notified about it. The main reason for this is for hooking up services like Solr or other indexers to update the entities even for ManyToMany relationships.
Member
|
Are you able to create a testcase that cover this lack of listener's notification? |
Contributor
Author
|
The test cases run successfully now, not sure how else to make sure that this change doesn't impact in a weird way in the rest of the codebase. I'm going to create some test cases to check that my change is triggering the proper event for entities with a ManyToMany relationship. |
Contributor
Author
|
The test case fails without my patch |
beberlei
added a commit
that referenced
this pull request
Mar 3, 2012
When using a ManyToMany relationship no listener is notified about any change to the owning entity
Member
|
And merged back into 2.1 and 2.2, see http://www.doctrine-project.org/jira/browse/DDC-1678 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm doing with this patch is marking the entity for update when there is a modification in the ManyToMany relationship so the listeners are notified about it.
The main reason for this is for hooking up services like Solr or other indexers to update the entities even for ManyToMany relationships.
This is the followup for #255