Skip to content

Entity manager persist and flush#29

Closed
hhamon wants to merge 2 commits intodoctrine:masterfrom
hhamon:entity_manager_persist_and_flush
Closed

Entity manager persist and flush#29
hhamon wants to merge 2 commits intodoctrine:masterfrom
hhamon:entity_manager_persist_and_flush

Conversation

@hhamon
Copy link

@hhamon hhamon commented Feb 9, 2011

Hello,

I have added a shortcut method to the EntityManager class: persistAndFlush()

Generally, developers need to persist and flush one single entity at a time. That means, we need to write two lines of code in controllers. The goal is to reduce a bit the number of lines of code by calling one single line of code, which is responsible to persist and flush the entity immediatly.

I didn't manage to run the tests suite so I cannot guarantee tests pass. Please, run the tests suite before applying the patch if you are convinced of its added value to the API.

Hugo Hamon
Sensio Labs Trainings Manager.

@beberlei
Copy link
Member

beberlei commented Feb 9, 2011

This is not really a good idea.

This encourages people to use persistAndFlush() on multiple new entities in a single request, leading to massive overhead. The separation is included for that reason that this are two completly different operations and the user should be confronted with this.

@hhamon
Copy link
Author

hhamon commented Feb 9, 2011

Ok no problem.

guilhermeblanco added a commit that referenced this pull request Jan 23, 2013
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants