Entity manager persist and flush#29
Closed
hhamon wants to merge 2 commits intodoctrine:masterfrom
hhamon:entity_manager_persist_and_flush
Closed
Entity manager persist and flush#29hhamon wants to merge 2 commits intodoctrine:masterfrom hhamon:entity_manager_persist_and_flush
hhamon wants to merge 2 commits intodoctrine:masterfrom
hhamon:entity_manager_persist_and_flush
Conversation
Member
|
This is not really a good idea. This encourages people to use persistAndFlush() on multiple new entities in a single request, leading to massive overhead. The separation is included for that reason that this are two completly different operations and the user should be confronted with this. |
Author
|
Ok no problem. |
guilhermeblanco
added a commit
that referenced
this pull request
Jan 23, 2013
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have added a shortcut method to the EntityManager class: persistAndFlush()
Generally, developers need to persist and flush one single entity at a time. That means, we need to write two lines of code in controllers. The goal is to reduce a bit the number of lines of code by calling one single line of code, which is responsible to persist and flush the entity immediatly.
I didn't manage to run the tests suite so I cannot guarantee tests pass. Please, run the tests suite before applying the patch if you are convinced of its added value to the API.
Hugo Hamon
Sensio Labs Trainings Manager.