Skip to content

Fix HAVING queries for PostgreSQL#301

Merged
beberlei merged 1 commit intodoctrine:masterfrom
sandermarechal:paginate-sql-walkers
Mar 13, 2012
Merged

Fix HAVING queries for PostgreSQL#301
beberlei merged 1 commit intodoctrine:masterfrom
sandermarechal:paginate-sql-walkers

Conversation

@sandermarechal
Copy link
Contributor

This should fix the failing unittests under PostgreSQL. I don't have psql myself, but from the description by @l3pp4rd in #298 this should fix the issue. Tested with SQLite and MySQL.

@asm89
Copy link
Member

asm89 commented Mar 13, 2012

If you go to http://travis-ci.org/ and login with your github account, you should be able to enable the doctrine2 repository. After doing that, travis will run the tests for you on various platforms like here: http://travis-ci.org/#!/doctrine/doctrine2.

Can you check it out? (For this branch you could do -> enable doctrine2 on travis -> force push the branch again.)

beberlei added a commit that referenced this pull request Mar 13, 2012
@beberlei beberlei merged commit 694d091 into doctrine:master Mar 13, 2012
@beberlei
Copy link
Member

Still fails http://travis-ci.org/#!/doctrine/doctrine2/jobs/852996

You have to do put everything in SELECT into GROUP BY, or make the SELECT simpler. I will try to find a fix, i guess its easier when you have postgresql to test against. Thanks for trying anyways :-)

@l3pp4rd
Copy link

l3pp4rd commented Mar 13, 2012

yes, it shouldn't be hard to install, the previous error is fixed, now the other one

@sandermarechal
Copy link
Contributor Author

I never realised that I could put my own fork on Travis as well. Thanks! I fixed it. It's all green now: http://travis-ci.org/#!/sandermarechal/doctrine2

I'll create a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants