improved exception message#330
Merged
asm89 merged 1 commit intodoctrine:masterfrom May 4, 2012
schmittjoh:betterExMessage
Merged
improved exception message#330asm89 merged 1 commit intodoctrine:masterfrom schmittjoh:betterExMessage
asm89 merged 1 commit intodoctrine:masterfrom
schmittjoh:betterExMessage
Conversation
Member
|
There is a test for this exception that will break after the message change. Can you upate tests/Doctrine/Tests/ORM/Mapping/ClassMetadataTest.php? Its the last test. |
Member
|
ping @schmittjoh |
Member
Author
|
If someone who has the test suite setup could quickly update the message, I'd appreciate that. As I said, I can't run it atm. |
Member
|
👍 done |
Member
Author
|
Thanks! On Fri, May 4, 2012 at 11:26 AM, Alexander <
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the exception message more helpful. Before you were basically searching a needle in a haystack.
Note that I haven't been able to run the tests because I don't have PHPUnit 3.6 atm, so please check before merging.