Fix identifier generator strategy for composite identifier#342
Closed
jeanmonod wants to merge 1 commit intodoctrine:masterfrom
Closed
Fix identifier generator strategy for composite identifier#342jeanmonod wants to merge 1 commit intodoctrine:masterfrom
jeanmonod wants to merge 1 commit intodoctrine:masterfrom
Conversation
Member
|
Hm, apart from the CS issues in your code, I'm wondering if setting the identifier strategy to NONE is the appropriate solution here. |
Author
|
I'm not sure if it's there is an other appropriate strategy available. But I think that with composite identifiers, it can't be an automatic strategy? Isn't it? |
Member
|
@jeanmonod CS means Coding Standards |
simensen
pushed a commit
to simensen/doctrine2
that referenced
this pull request
Jun 27, 2012
|
Maybe this patch needs to be ported on XmlExporter.php as well ? Because bug [DDC-1798] is also affecting XML exporter. |
Member
|
@odoucet please send a pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the ConvertMappingCommand on a schema that contain a table with a composite key, we got the exception:
This can be fix by setting the identifier strategy to NONE for composite identifier fields