[DDC-1872] add tests to evaluate annotations overrides with traits#412
Closed
cordoval wants to merge 1 commit intodoctrine:masterfrom
Closed
[DDC-1872] add tests to evaluate annotations overrides with traits#412cordoval wants to merge 1 commit intodoctrine:masterfrom
cordoval wants to merge 1 commit intodoctrine:masterfrom
Conversation
Member
|
We cant merge 5.4 code into Doctrine. I don't know a way in phpunit to conditionally skip code via the phpunit.xml, i think thats not possible. |
Contributor
Author
|
hey don't worry I will use php5.3 compatible code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP RFC
please let me know if this is ok and i just need to move the classes to the DDC-1872 folders
now I will work on the tutorial for the documentation
with @raul782