Conversation
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
…arams alignment issues)
.travis.yml
Outdated
There was a problem hiding this comment.
would this make the build fail in case of a CS violation ? I'm not sure it is the best idea.
|
Yes, this fails! But i could remove the .travis.yml modification from the pull request. |
|
wow, finally Doctrine2 follows PSR2! |
|
Not yet. Lot's of work to be done before this happens. But it's time. |
There was a problem hiding this comment.
Please don't do this. Renaming a protected property is a BC break (for people extending the class) so it cannot be done until Doctrine 3
There was a problem hiding this comment.
and this is of course true for all protected properties in the codebase
This fixes several PSR2 issues and enables the php-cs-fixer and phpcs PSR2 checks in travis.