Skip to content

Hotfix/psr2#468

Closed
jakoch wants to merge 14 commits intodoctrine:masterfrom
jakoch:hotfix/PSR2
Closed

Hotfix/psr2#468
jakoch wants to merge 14 commits intodoctrine:masterfrom
jakoch:hotfix/PSR2

Conversation

@jakoch
Copy link
Contributor

@jakoch jakoch commented Oct 10, 2012

This fixes several PSR2 issues and enables the php-cs-fixer and phpcs PSR2 checks in travis.

@doctrinebot
Copy link

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2063

.travis.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this make the build fail in case of a CS violation ? I'm not sure it is the best idea.

@jakoch
Copy link
Contributor Author

jakoch commented Oct 10, 2012

Yes, this fails! But i could remove the .travis.yml modification from the pull request.

@Koc
Copy link
Contributor

Koc commented Oct 10, 2012

wow, finally Doctrine2 follows PSR2!

@jakoch
Copy link
Contributor Author

jakoch commented Oct 10, 2012

Not yet. Lot's of work to be done before this happens. But it's time.
Please see https://travis-ci.org/#!/jakoch/doctrine2/jobs/2732759/L116

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this. Renaming a protected property is a BC break (for people extending the class) so it cannot be done until Doctrine 3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this is of course true for all protected properties in the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants