Replaced the setting of Ids to the whereInQuery with a more performant implementation#476
Closed
HarmenM wants to merge 3 commits intodoctrine:masterfrom
HarmenM:master
Closed
Replaced the setting of Ids to the whereInQuery with a more performant implementation#476HarmenM wants to merge 3 commits intodoctrine:masterfrom HarmenM:master
HarmenM wants to merge 3 commits intodoctrine:masterfrom
HarmenM:master
Conversation
added 2 commits
October 12, 2012 14:21
replaced the for-loop which adds the InputParameters for a single InputParameter for use with an array instead of a set of scalars.
Replaced the foreach loop adding all IDs as single parameters with a single parameter which injects the IDs as an array.
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
Member
|
Could you update the tests to match the newly generated SQL? |
Member
|
ping |
Author
|
And hereby the updated tests. |
Member
|
Merged into master and 2.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with large datasets in combination with pagination (ie. a pagination window of 100 or more), the performance drastically decreased.
I tracked the problem down to the setting of the parameters. In the old implementation, the parameters are set individually. This pull request sets the parameter as an array to the Query and Walker.
Testing results (# of entities, original performance, improved performance):
32 0,036 0,033
64 0,043 0,037
128 0,065 0,043
256 0,133 0,057
512 0,360 0,088
1024 1,212 0,157
2048 4,462 0,332
4096 17,203 0,818