[DDC-2113] Surround WHERE clause with parens if using SQLFilter#495
Closed
vclayton wants to merge 735 commits intodoctrine:2.2from
Closed
[DDC-2113] Surround WHERE clause with parens if using SQLFilter#495vclayton wants to merge 735 commits intodoctrine:2.2from
vclayton wants to merge 735 commits intodoctrine:2.2from
Conversation
remove svn markers
[DDC-1845] QuoteStrategy
fixed typo in command help text
Added an empty line feed preceding the return statement
…istence\Mapping\Driver\MappingDriver
SimplifiedXmlDriver and SimplifiedYamlDriver are still not valid after this commit
Fixed bug with comment option not being added to column.
fixed typo/bug and CS on use statements
While executing updates on an entity scheduled for update without a change-set, an "Undefined index" notice is raised.
Fix DDC-2079
Fix DDC-2069
Prevented "Undefined index" notice when updating
Fixed empty namespace in generated code when repository class do not have namespace
add bool detection when inferring type
check for false as a return value from get_parent_class(), not null
fix StatementMock bindParam parameters
remove unused use statements
Added NOT LIKE expression
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
|
Oh btw, I just (automatically) realized that you are not creating this pull request against the master branch. Unless there are good reasons for this, i would suggest to close and rebase the Pull Request against master and then create it again. Sorry! |
Author
|
I'll recreate it in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch to address DDC-2113, by surrounding the WHERE clause conditional with parens if there are any filterClauses