added fix for unsigned option in column defintion#500
Conversation
…ouples ER implementation from EM, as it should be.
…interface, not ORM class.
…ment to 5.3.9. Changed to reflection approach which still keep us at the same dependency as before.
[2.3] Use HelperSet in cli-config.php
… field to null explicitly to override possible previous values.
[DDC-1961] Fixed parameter type support in Parameter
…() method instead of having to implement themselves.
This allows multiple hydrators to be set at once, and also allows for the customHydrationMode options to be set via DoctrineORMModule
…ing reverse engineering.
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
|
@SebastianBauer could you please add a test that shows what the problem you attempt to fix is? Also, please don't merge upstream next time: instead, rebase. If you can, please squash those commits so that the merges don't cause a mess once this PR is merged :) |
There was a problem hiding this comment.
Missing empty line before this if
|
Hi Marco, thanks for your feedback. It's my first PR, trying to fix the commits. Going to add a test as well. Sebastian Am Sonntag, 4. November 2012 schrieb Marco Pivetta :
Sebastian Bauer sebastian.bauer@sb3w.com - E-Mail, Jabber |
|
@SebastianBauer no worries :) Just push the changes to the same branch and the PR will be updated automatically. Focus on the test only eventually. If you cannot manage to squash the commits, it can be merged manually. |
|
I have to cleanup my branch. Trying to fix the commits needs more time when doing that for the first time. ;) Hope to have a update tomorrow afternoon. |
ghost
closed this
|
Sorry, my repo is totally broken now. ;) I just will send a new PR. |
15 participants
Just checking in SchemaTool if unsigned option is set and take this value.