another attempt to allow parent methods in generated proxy classes to pass along all args#68
Closed
shaunxcode wants to merge 3 commits intodoctrine:masterfrom
shaunxcode:master
Closed
another attempt to allow parent methods in generated proxy classes to pass along all args#68shaunxcode wants to merge 3 commits intodoctrine:masterfrom shaunxcode:master
shaunxcode wants to merge 3 commits intodoctrine:masterfrom
shaunxcode:master
Conversation
… which may use func_get_args internally. Previously they would be passed nothing and thus fail. Also reduces need to build up argumentString.
…aid arguments to the parent method via func_get_args.
Member
|
This doesn't make sense, you can use func_get_args() starting at parameter 2, for example see array_map() |
Member
|
There is really no way to avoid using the approach you did in the previous PR, however that is not an option in my opinion. I updated the docs already to reflect the issue that func_get_args() is not supported in entities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After considering your feedback re performance I have made it only use the call_user_func_array approach in the case that there are no params to the arg which means it MAY be using func_get_args internally in the parent method.