Now findByOne really retrieve only one entity adding limit to query#86
Merged
guilhermeblanco merged 2 commits intodoctrine:masterfrom Jul 21, 2011
kwiateusz:findByOne-patch
Merged
Now findByOne really retrieve only one entity adding limit to query#86guilhermeblanco merged 2 commits intodoctrine:masterfrom kwiateusz:findByOne-patch
guilhermeblanco merged 2 commits intodoctrine:masterfrom
kwiateusz:findByOne-patch
Conversation
guilhermeblanco
added a commit
that referenced
this pull request
Jul 21, 2011
Now findByOne really retrieve only one entity adding limit to query
guilhermeblanco
added a commit
that referenced
this pull request
Jul 22, 2011
Contributor
Author
|
What was broken? I'll try to make this works properly |
Member
|
This fix breaks our Proxy support and makes our suite throws an E_FATAL. I had to revert it because it broke many other tests too. You can try to implement a better patch by locally applying your fix and running phpunit on root got clone of orm. Cheers, |
guilhermeblanco
added a commit
that referenced
this pull request
Jan 23, 2013
Docs for NamingStrategy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For me it's stupidity when doctrine make "select * from" query then in php return only one entity. Name of the function says' one! So why doctrine is torturing mysql (in my project it try to retrive ~300k records and then return only one...)