Improve phpdoc about list#315
Merged
greg0ire merged 1 commit intodoctrine:3.1.xfrom Nov 18, 2022
VincentLanglet:list
Merged
Conversation
greg0ire
reviewed
Nov 18, 2022
Contributor
Author
I personally would have prefer this to be released asap to avoid static analysis issues with but I understand. I updated the branch. |
Member
|
I will look into doing a release soon, ping me if I don't :) |
greg0ire
approved these changes
Nov 18, 2022
|
@greg0ire Can we please have this backported to v2 branch and tag a new release as v2 has the same problem that this PR solved for v3 so the CI build on our project is currently failing. I can do the backport if the change is gonna be merged. |
Member
|
Yes: persistence/.doctrine-project.json Line 33 in 8bf8ab1 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got an error from phpstan for the following code
Looking at the
getAllMetadataimplementation the return value is a list.So I tried updated some phpdoc when the method is returning a list.