Replace string matching with syscall error checking for connection resets#22
Merged
gerhardgruber merged 4 commits intogg/connection_reset_status_checkfrom Nov 25, 2025
Merged
Conversation
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update connection reset status check implementation
Replace string matching with syscall error checking for connection resets
Nov 25, 2025
…on resets Co-authored-by: gerhardgruber <1944892+gerhardgruber@users.noreply.github.com>
Co-authored-by: gerhardgruber <1944892+gerhardgruber@users.noreply.github.com>
67890f1 to
67aca20
Compare
gerhardgruber
approved these changes
Nov 25, 2025
b6bff46
into
gg/connection_reset_status_check
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connection reset detection relied on string matching against platform-specific error messages ("connection was forcibly closed by the remote host" on Windows, "connection reset by peer" on Unix). This is fragile and breaks across Go versions or platforms.
Changes:
errors.Is(opErr.Err, syscall.ECONNRESET)instead of string matchingstringsimport, addsyscallimportECONNRESET(Unix) andWSAECONNRESET(Windows) automaticallyBefore:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.