Make dialog into a component#31
Merged
ElTimuro merged 4 commits intodocumenso:mainfrom Mar 28, 2023
ephraimduncan:doc-82
Merged
Make dialog into a component#31ElTimuro merged 4 commits intodocumenso:mainfrom ephraimduncan:doc-82
ElTimuro merged 4 commits intodocumenso:mainfrom
ephraimduncan:doc-82
Conversation
ElTimuro
approved these changes
Mar 28, 2023
Member
ElTimuro
left a comment
ElTimuro
left a comment
There was a problem hiding this comment.
Looks good so far. The dialog in this form is still not reusable. We should generalize this, when doing the next one
Member
|
@dephraiim see my comment above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22