New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose #options attribute #26

Merged
merged 1 commit into from Jan 24, 2013

Conversation

Projects
None yet
2 participants
@alunny
Contributor

alunny commented Jan 23, 2013

Motivation: when using Jammit with multiple packages, it is useful to vary options given to the jar based on an individual package.

For example, to generate source maps the closure compiler takes an option --create_source_map, with the path for the output source map. If I have 3 packages in my Jammit assets.yml, the last one to be packaged will overwrite the source map file (as the 2nd one will have already done to the 1st).

(actually getting Jammit to do this correctly will require some changes in that project; a pull request there is forthcoming)

This patch allows the options hash to be changed for each run, without creating a new Closure::Compiler object. Creating a new object is feasible too, although a bit less clean imo.

jashkenas added a commit that referenced this pull request Jan 24, 2013

Merge pull request #26 from alunny/master
expose #options attribute

@jashkenas jashkenas merged commit 0484508 into documentcloud:master Jan 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment