Conversation
* 'master' of https://github.com/documentcloud/jammit: Jammit 0.6.5 Jammit 0.6.4 fix nasty-ish bug where JS would always be recompiled, regardless. Accept an options parameter in Jammit::Helper#include_javascripts (cherry picked from commit 9da79ca) Adding command-line and config_file option for overriding PUBLIC_ROOT. Read JS files as UTF-8. Fixes #198
… bin_root * 'master' of https://github.com/documentcloud/jammit: Fixes a typo. Fixed SASS test, it actually cares about single vs double quotes. Actually sets :jsmin as DEFAULT_JAVASCRIPT_COMPRESSOR AND :cssmin as DEFAULT_CSS_COMPRESSOR. They both are loaded inside `lib/jammit/dependencies.rb` cssmin and jsmin is the new minimum requirements of jammit. YUI is now optional. Added sass, cssmin, and jsmin to Gemfile as part of development+test requirements. Removed unecessary abstraction of YUI compressors. Refactor of Jammit. Late instantiation of Jammit::Compressor Added test for no-rewrite-relative-paths. Replace invalid font/* MIME types with valid ones, to suppress WebKit warnings Bad merge. Added rewrite_relative_paths. Erase has_rdoc Edit s.date = to current date time with proper format Fix for undefined RAILS_ENV (when running under Rake there's no Rails.env).
Member
|
What exactly does it fix? When does |
Member
Author
|
If the binary is a symlink, then |
jashkenas
added a commit
that referenced
this pull request
May 21, 2012
Use relative binary path for jammit on the command-line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote this a while ago, but I think it's time for a pull request to at least debate its merits. Uses realpath instead of wrongpath.