Skip to content

fix for using 'sass' css compressor#236

Merged
jashkenas merged 1 commit intodocumentcloud:masterfrom
ryankshaw:master
Oct 9, 2012
Merged

fix for using 'sass' css compressor#236
jashkenas merged 1 commit intodocumentcloud:masterfrom
ryankshaw:master

Conversation

@ryankshaw
Copy link
Copy Markdown
Contributor

running jammit using the 'sass' css compressor would
fail because this method expects at least 2 arguments

see: http://sass-lang.com/docs/yardoc/Sass/SCSS/Parser.html#initialize-instance_method

since, at this point, it is just the combined
input for all of the files in a bundle, there is no
real filename i just called it 'jammit-combined-input'

running jammit using the 'sass' css compressor would
fail because this method expects at least 2 arguments

see: http://sass-lang.com/docs/yardoc/Sass/SCSS/Parser.html#initialize-instance_method

since, at this point, it is just the combined
input for all of the files in a bundle, there is no
real filename i just called it 'jammit-combined-input'
@ryankshaw
Copy link
Copy Markdown
Contributor Author

@jashkenas can you merge this? it's pretty simple and straightforward and makes it so using the sass compressor actually works.

@jashkenas
Copy link
Copy Markdown
Member

Sure -- thanks.

jashkenas added a commit that referenced this pull request Oct 9, 2012
fix for using 'sass' css compressor
@jashkenas jashkenas merged commit 72453bb into documentcloud:master Oct 9, 2012
@ryankshaw
Copy link
Copy Markdown
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants