Allows use of Istio and adds multi-cloud global strong scripts #133
Conversation
| --authenticationMechanism SCRAM-SHA-256 --tls --tlsAllowInvalidCertificates | ||
| ``` | ||
|
|
||
| ### Failover Operations |
There was a problem hiding this comment.
should we market our plugin or not?
There was a problem hiding this comment.
I don't think so yet.
|
Since we want to rework the token servcie we shoudl mark that all with TODO's to make sure it's clear that we are still thinking about the best way. |
alaye-ms
force-pushed
the
istioScripts
branch
from
c9350a7 to
b6923a5
Compare
|
|
||
| // Configure storage class - use specified storage class or nil for default | ||
| var storageClass *string | ||
| if documentdb.Spec.Resource.Storage.StorageClass != "" { |
There was a problem hiding this comment.
We are removing this line means for single cluster setup in AWS or GKE it will fail unless we are passing it right. From the controller I see we are only passing replicationContext.StorageClass but not from spec.
There was a problem hiding this comment.
I never tried AWS without a storage class, I just ran it that way because your sample scripts had a special storage class. GKE doesn't need a non-default storage class. This is so that each member cluster can have their own unique class in the membercluster list, single cluster operations shouldn't be changed by this
There was a problem hiding this comment.
For customers who want to pass a specific storageClass for single cloud/cluster setup, they will use this documentdb.Spec.Resource.Storage.StorageClass spec config. Where are we evaluating that then?
There was a problem hiding this comment.
In replication_context.go line 48
| @@ -0,0 +1,100 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
We should keep this script folder clean. Only the scripts which are used/run the the operator itself or we need inside the host machine.
All other setup scripts for different environment should go under documentdb-playground/ specific folder.
3 participants
No description provided.