Multi-Region Backup and Restore #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WentingWu666666
requested review from
alaye-ms,
hossain-rayhan and
xgerman
as code owners
WentingWu666666
force-pushed
the
users/wentingwu/multi-region-backup-2
branch
from
fcc4575 to
bf52fb6
Compare
Open
hossain-rayhan
approved these changes
Nov 7, 2025
| // IsDone returns true if the backup operation is completed or failed. | ||
| func (backupStatus *BackupStatus) IsDone() bool { | ||
| return backupStatus.Phase == cnpgv1.BackupPhaseCompleted || backupStatus.Phase == cnpgv1.BackupPhaseFailed | ||
| return backupStatus.Phase == cnpgv1.BackupPhaseCompleted || backupStatus.Phase == cnpgv1.BackupPhaseFailed || backupStatus.Phase == BackupPhaseSkipped |
Collaborator
There was a problem hiding this comment.
I believe it will work fine with new initial state. Still, did we verify double backup? Like we finished a backup five minutes ago with status completed, then trigger another backup? It should take second backup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.