-
Notifications
You must be signed in to change notification settings - Fork 11
Create a plugin to add a WAL Receiver pod #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alaye-ms
wants to merge
10
commits into
documentdb:main
Choose a base branch
from
alaye-ms:walReceiverPlugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,496
−0
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
206f6fc
add plugin
alaye-ms ee447cb
use new service account
alaye-ms 28cae36
fix reconciler and disable operator
alaye-ms bae9bbf
use proper user and different default values
alaye-ms d32bd56
Add examples and start making custom image
alaye-ms e8534ec
distroless image first go
alaye-ms 4469daf
add wal slot creation to the plugin
alaye-ms fa8b988
remove non-working dockerfile
alaye-ms ea15d4d
Update docs
alaye-ms e5ada08
remove plugin-side primary detection
alaye-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| bin/ | ||
| dist/ | ||
| .env | ||
| .vscode/ | ||
| .idea/ | ||
| .task/ | ||
| manifest.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT License. | ||
|
|
||
| # Step 1: build image | ||
| FROM golang:1.24 AS builder | ||
|
|
||
| # Cache the dependencies | ||
| WORKDIR /app | ||
| COPY go.mod go.sum /app/ | ||
| RUN go mod download | ||
|
|
||
| # Compile the application | ||
| COPY . /app | ||
| RUN --mount=type=cache,target=/root/.cache/go-build ./scripts/build.sh | ||
|
|
||
| # Step 2: build the image to be actually run | ||
| FROM golang:1-alpine | ||
| USER 10001:10001 | ||
| COPY --from=builder /app/bin/cnpg-i-wal-replica /app/bin/cnpg-i-wal-replica | ||
| ENTRYPOINT ["/app/bin/cnpg-i-wal-replica"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| DocumentDB Kubernetes Operator | ||
|
|
||
| Copyright (c) Microsoft Corporation. | ||
|
|
||
| MIT License | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,190 @@ | ||
| # WAL Replica Pod Manager (CNPG-I Plugin) | ||
|
|
||
| This plugin creates a standalone WAL receiver deployment alongside a [CloudNativePG](https://github.com/cloudnative-pg/cloudnative-pg/) cluster. It automatically provisions a Deployment named `<cluster-name>-wal-receiver` that continuously streams Write-Ahead Log (WAL) files from the primary PostgreSQL cluster using `pg_receivewal`, with support for both synchronous and asynchronous replication modes. | ||
|
|
||
| ## Features | ||
|
|
||
| - **Automated WAL Streaming**: Continuously receives and stores WAL files from the primary cluster | ||
| - **Persistent Storage**: Automatically creates and manages a PersistentVolumeClaim for WAL storage | ||
| - **TLS Security**: Uses cluster certificates for secure replication connections | ||
| - **Replication Slot Management**: Automatically creates and manages a dedicated replication slot (`wal_replica`) | ||
| - **Synchronous Replication Support**: Configurable synchronous/asynchronous replication modes | ||
| - **Cluster Lifecycle Management**: Automatically manages resources with proper owner references | ||
|
|
||
| ## Configuration | ||
|
|
||
| Add the plugin to your Cluster specification: | ||
|
|
||
| ```yaml | ||
| apiVersion: postgresql.cnpg.io/v1 | ||
| kind: Cluster | ||
| metadata: | ||
| name: my-cluster | ||
| spec: | ||
| instances: 3 | ||
|
|
||
| plugins: | ||
| - name: cnpg-i-wal-replica.documentdb.io | ||
| parameters: | ||
| image: "ghcr.io/cloudnative-pg/postgresql:16" | ||
| replicationHost: "my-cluster-rw" | ||
| synchronous: "active" | ||
| walDirectory: "/var/lib/postgresql/wal" | ||
| walPVCSize: "20Gi" | ||
|
|
||
| replicationSlots: | ||
| synchronizeReplicas: | ||
| enabled: true | ||
|
|
||
| storage: | ||
| size: 10Gi | ||
| ``` | ||
|
|
||
| ### Parameters | ||
|
|
||
| | Parameter | Type | Default | Description | | ||
| |-----------|------|---------|-------------| | ||
| | `image` | string | Cluster status image | Container image providing `pg_receivewal` binary | | ||
| | `replicationHost` | string | `<cluster>-rw` | Primary host endpoint for WAL streaming | | ||
| | `synchronous` | string | `inactive` | Replication mode: `active` (synchronous) or `inactive` (asynchronous) | | ||
| | `walDirectory` | string | `/var/lib/postgresql/wal` | Directory path for storing received WAL files | | ||
| | `walPVCSize` | string | `10Gi` | Size of the PersistentVolumeClaim for WAL storage | | ||
|
|
||
| #### Synchronous Modes | ||
|
|
||
| - **`active`**: Enables synchronous replication with `--synchronous` flag | ||
| - **`inactive`**: Standard asynchronous replication (default) | ||
|
|
||
| ## Architecture | ||
|
|
||
| The plugin creates the following Kubernetes resources: | ||
|
|
||
| 1. **Deployment**: `<cluster-name>-wal-receiver` | ||
| - Single replica pod running `pg_receivewal` | ||
| - Configured with proper security context (user: 105, group: 103) | ||
| - Automatic restart policy for high availability | ||
|
|
||
| 2. **PersistentVolumeClaim**: `<cluster-name>-wal-receiver` | ||
| - Stores received WAL files persistently | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we need some retention policy - should integrate with backup interval or so. Ok, to make ToDo for now - but we really should delete stuff so the disk doesn't flow over |
||
| - Uses `ReadWriteOnce` access mode | ||
| - Configurable size via `walPVCSize` parameter | ||
|
|
||
| 3. **Volume Mounts**: | ||
| - WAL storage: Mounted at configured `walDirectory` | ||
| - TLS certificates: Mounted from cluster certificate secrets | ||
| - CA certificates: Mounted for SSL verification | ||
|
|
||
| ## Security | ||
|
|
||
| The plugin implements comprehensive security measures: | ||
|
|
||
| - **TLS Encryption**: All replication connections use SSL/TLS | ||
| - **Certificate Management**: Automatically mounts cluster CA and client certificates | ||
| - **User Privileges**: Runs with dedicated PostgreSQL user and group IDs | ||
| - **Connection Authentication**: Uses `streaming_replica` user with certificate-based auth | ||
|
|
||
| ## Prerequisites | ||
|
|
||
| - CloudNativePG operator installed and running | ||
| - CNPG-I (CloudNativePG Interface) framework deployed | ||
| - Cluster with enabled replication slots synchronization | ||
| - Sufficient storage for WAL files retention | ||
|
|
||
| ## Installation | ||
|
|
||
| ### Building from Source | ||
|
|
||
| ```bash | ||
| # Clone the repository | ||
| git clone https://github.com/documentdb/cnpg-i-wal-replica | ||
| cd cnpg-i-wal-replica | ||
|
|
||
| # Build the binary | ||
| go build -o bin/cnpg-i-wal-replica main.go | ||
| ``` | ||
|
|
||
| ### Using Docker | ||
|
|
||
| ```bash | ||
| # Build container image | ||
| docker build -t cnpg-i-wal-replica:latest . | ||
| ``` | ||
|
|
||
| ### Deployment Scripts | ||
|
|
||
| ```bash | ||
| # Make scripts executable | ||
| chmod +x scripts/build.sh scripts/run.sh | ||
|
|
||
| # Build and run | ||
| ./scripts/build.sh | ||
| ./scripts/run.sh | ||
| ``` | ||
|
|
||
| ## Monitoring and Observability | ||
|
|
||
| The WAL receiver pod provides verbose logging when enabled, including: | ||
|
|
||
| - Connection status to primary cluster | ||
| - WAL file reception progress | ||
| - Replication slot status | ||
| - SSL/TLS connection details | ||
|
|
||
| ## Examples | ||
|
|
||
| See the `doc/examples/` directory for complete cluster configurations: | ||
|
|
||
| - [`cluster-example.yaml`](doc/examples/cluster-example.yaml): Basic configuration | ||
| - [`cluster-example-no-parameters.yaml`](doc/examples/cluster-example-no-parameters.yaml): Default settings | ||
| - [`cluster-example-with-mistake.yaml`](doc/examples/cluster-example-with-mistake.yaml): Common configuration errors | ||
|
|
||
| ## Development | ||
|
|
||
| ### Project Structure | ||
|
|
||
| ``` | ||
| ├── cmd/plugin/ # Plugin command-line interface | ||
| ├── internal/ | ||
| │ ├── config/ # Configuration management | ||
| │ ├── identity/ # Plugin identity and metadata | ||
| │ ├── k8sclient/ # Kubernetes client utilities | ||
| │ ├── operator/ # Operator implementations | ||
| │ └── reconciler/ # Resource reconciliation logic | ||
| ├── kubernetes/ # Kubernetes manifests | ||
| ├── pkg/metadata/ # Plugin metadata and constants | ||
| └── scripts/ # Build and deployment scripts | ||
| ``` | ||
|
|
||
| ### Running Tests | ||
|
|
||
| ```bash | ||
| go test ./... | ||
| ``` | ||
|
|
||
| See [`doc/development.md`](doc/development.md) for detailed development guidelines. | ||
|
|
||
| ## Limitations and Future Enhancements | ||
|
|
||
| ### Current Limitations | ||
|
|
||
| - Fixed compression level (disabled: `--compress 0`) | ||
| - No built-in WAL retention/cleanup policies | ||
| - Limited resource configuration options | ||
|
|
||
| ### Planned Enhancements | ||
|
|
||
| - [ ] Configurable resource requests and limits | ||
| - [ ] WAL retention and garbage collection policies | ||
| - [ ] Health checks and readiness probes | ||
| - [ ] Metrics exposure for monitoring integration | ||
| - [ ] Multi-zone/region WAL archiving support | ||
| - [ ] Backup integration with existing CNPG backup strategies | ||
|
|
||
| ## License | ||
|
|
||
| This project is licensed under the MIT License - see the [LICENSE](LICENSE) file for details. | ||
|
|
||
| ## Contributing | ||
|
|
||
| Contributions are welcome! Please read [CONTRIBUTING.md](../../CONTRIBUTING.md) for guidelines on how to contribute to this project. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| // Package plugin implements the command to start the plugin | ||
| package plugin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package plugin | ||
|
|
||
| import ( | ||
| "github.com/cloudnative-pg/cnpg-i-machinery/pkg/pluginhelper/http" | ||
| "github.com/cloudnative-pg/cnpg-i/pkg/operator" | ||
| "github.com/cloudnative-pg/cnpg-i/pkg/reconciler" | ||
| "github.com/spf13/cobra" | ||
| "google.golang.org/grpc" | ||
| "sigs.k8s.io/controller-runtime/pkg/log" | ||
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | ||
|
|
||
| "github.com/documentdb/cnpg-i-wal-replica/internal/identity" | ||
| operatorImpl "github.com/documentdb/cnpg-i-wal-replica/internal/operator" | ||
| reconcilerImpl "github.com/documentdb/cnpg-i-wal-replica/internal/reconciler" | ||
| ) | ||
|
|
||
| // NewCmd creates the `plugin` command | ||
| func NewCmd() *cobra.Command { | ||
| cmd := http.CreateMainCmd(identity.Implementation{}, func(server *grpc.Server) error { | ||
| // Register the declared implementations | ||
| operator.RegisterOperatorServer(server, operatorImpl.Implementation{}) | ||
| reconciler.RegisterReconcilerHooksServer(server, reconcilerImpl.Implementation{}) | ||
| return nil | ||
| }) | ||
|
|
||
| logger := zap.New(zap.UseDevMode(true)) | ||
| log.SetLogger(logger) | ||
|
|
||
| cmd.Use = "receivewal" | ||
|
|
||
| return cmd | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this what CNPG does? Or could we go distroless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do distroless, cnpg uses gcr.io/distroless/static-debian12:nonroot