Merged
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
384df01 to
a601934
Compare
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
a601934 to
1a38c88
Compare
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
25b8a87 to
4f33fa7
Compare
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
cdd6c1b to
789a6e6
Compare
Collaborator
Author
|
The 2 remaining CI failures are the expected Once #79 is merged I can mark these as expected failures for MongoDB, but I don't want to duplicate the framework effort for adding that machinery. |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
manojnks
approved these changes
Apr 16, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
eerxuan
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds
$converttests.Covers:
binDataconversions andsubtypehandlingformatandbyteOrderparametersonErrorandonNullbehaviorThe
$convertoperator is the general form behind$toString,$toInt,$toDouble, etc. The various$to*tests are already parametrized over both the native operator and the equivalent$convertexpression, so the test coverage is completely identical and there is no need to duplicate those test cases. The tests included here are unique to$convert, covering options that are not applicable to the$to*operators.Note: there is a possible MongoDB bug where converting a
Datewith year outside 0-9999 tostringproduces error code 18537 (DateToStringYearRange) that is not caught byonError, unlike all other conversion errors. Thedate_str_year_err_on_error_caught_*tests document the correct behavior whereonErrorhandles this case, and are expected to fail against a server with this bug.