Open
Conversation
sathvikprasad97
suggested changes
Apr 21, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
danielfrankcom
force-pushed
the
pr/project-stage-tests
branch
from
417afb3 to
edf28f5
Compare
sathvikprasad97
approved these changes
Apr 22, 2026
eerxuan
requested changes
Apr 22, 2026
Collaborator
eerxuan
left a comment
eerxuan
left a comment
There was a problem hiding this comment.
Cross checking with PR132, no test for not exist collection. collection.drop() then run command. This case is stages specific, so need in every stage. stage like $collStats will fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces tests for the
$projectaggregation stage.I also renamed three error code constants to better reflect their semantics. These weren't used elsewhere as they were added recently based on my first cut at these tests.