Add $listCollections command tests#156
Merged
eerxuan merged 6 commits intodocumentdb:mainfrom May 4, 2026
Merged
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (4786+33 LOC, 20 files); LLM: Adds new test cases for the $listCollections command, expanding test coverage in the compatibility tests directory. If a label is wrong, remove it manually and ping |
documentdb-triage-tool
Bot
added
compatibility test
Ne(0) is vacuously true because cursor.id is Int64 and strict_equal rejects cross-type numeric comparisons. Use INT64_ZERO so the assertion actually validates the cursor is open. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Remove non-boundary Decimal128 cases that don't distinguish banker's rounding from standard rounding. Keep only the .5 boundary cases (0.5, 1.5, 2.5) that exercise round-half-to-even in both directions. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
The full Eq() match included server-expanded defaults like the ICU version string, which is an implementation detail. Use Exists() for the collation object and Eq() only for the requested locale. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Ne() with a mismatched numeric type (e.g. Ne(int(0)) against Int64) is vacuously true because strict_equal rejects cross-type numerics. Detect this and fail with a clear diagnostic. Uses type() membership rather than isinstance() to avoid false positives on bool. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
sathvikprasad97
approved these changes
May 4, 2026
eerxuan
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
$listCollectionscommand.Note that the
assertPropertiespatterns from #144 have been included here, since the other change has not been merged yet.