Skip to content

Add $sum accumulator tests#186

Merged
eerxuan merged 2 commits into
documentdb:mainfrom
alinaliBQ:sum
May 15, 2026
Merged

Add $sum accumulator tests#186
eerxuan merged 2 commits into
documentdb:mainfrom
alinaliBQ:sum

Conversation

@alinaliBQ
Copy link
Copy Markdown
Contributor

@alinaliBQ alinaliBQ commented May 14, 2026

This change adds tests for the $sum accumulator operator.
This PR starts off the accumulator series and creates AccumulatorTestCase.

Add stage operator tests for $sum. Tests database $sum behavior, output collection, syntax, and expected errors.
Integration tests are in documentdb_tests/compatibility/tests/core/operator/accumulators/test_accumulators_sum_integration.py

@documentdb-triage-tool
Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status In Progress
Confidence: 0.92 (mixed)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (1943+0 LOC, 11 files); LLM: Adds new integration test coverage for the $sum accumulator operator under the compatibility tests path, covering behavior, output, syntax, and error cases.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels May 14, 2026
@alinaliBQ alinaliBQ force-pushed the sum branch 2 times, most recently from 3e57cf2 to 2d66620 Compare May 14, 2026 23:24
@alinaliBQ alinaliBQ marked this pull request as ready for review May 14, 2026 23:45
@alinaliBQ alinaliBQ requested a review from a team as a code owner May 14, 2026 23:45
Copy link
Copy Markdown

@SaiPradyumn SaiPradyumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR covers $sum in depth.

- used sum test cases generated locally and added test cases from daniel F's generated tests to close the gap.
- squashed commits into 1 to rebase on top of `main`

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@eerxuan eerxuan merged commit f35ee84 into documentdb:main May 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants