Add aggregate command tests#221
Open
danielfrankcom wants to merge 8 commits into
Open
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (11743+10 LOC, 44 files); LLM: Adds new test coverage for the If a label is wrong, remove it manually and ping |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Collaborator
Author
|
Added a few more tests for collation based on work in #225. There are some aspects of collation that make more sense in this directory as they are part of the command syntax rather than collation behavior. |
eerxuan
reviewed
May 26, 2026
yshanhu
reviewed
May 27, 2026
yshanhu
reviewed
May 27, 2026
yshanhu
reviewed
May 27, 2026
yshanhu
reviewed
May 27, 2026
Remove collation subfield/semantic tests (covered in collation/), writeConcern fsync/getLastError/provenance tests (undocumented options), namespace naming rules (common spec), and thorough view tests (covered in collections/views/). Add collection type acceptance tests. Keep only command-specific syntax validation. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
danielfrankcom
force-pushed
the
pr/aggregate
branch
from
486f12d to
0ec5bc4
Compare
yshanhu
reviewed
May 27, 2026
yshanhu
reviewed
May 27, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
The comment field accepts any BSON type, which is already covered by test_aggregate_comment_types.py. Testing specific values within accepted types adds no compatibility signal. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
yshanhu
approved these changes
May 28, 2026
eerxuan
approved these changes
May 28, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
yshanhu
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
aggregatecommand.There is some overlap here with #191 as some of the framework changes are needed by both. I've included them here so they should merge cleanly.