Skip to content

Added geospatial tests for $maxDistance#224

Open
vic-tsang wants to merge 2 commits into
documentdb:mainfrom
vic-tsang:geospatial/maxDistance/tests
Open

Added geospatial tests for $maxDistance#224
vic-tsang wants to merge 2 commits into
documentdb:mainfrom
vic-tsang:geospatial/maxDistance/tests

Conversation

@vic-tsang
Copy link
Copy Markdown
Collaborator

This PR contains:

  • geospatial tests for $maxDistance

Ref:

Signed-off-by: Victor [C] Tsang <vitsangp@amazon.com>
@vic-tsang vic-tsang requested a review from a team as a code owner May 21, 2026 23:31
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels May 21, 2026
@documentdb-triage-tool
Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.85 (mixed)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (1180+0 LOC, 9 files); LLM: Adds new geospatial test cases for $maxDistance operator to the compatibility test suite, a straightforward test coverage expansion.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

Signed-off-by: Victor [C] Tsang <vitsangp@amazon.com>
@vic-tsang vic-tsang requested a review from fanyangv May 26, 2026 21:29
Copy link
Copy Markdown
Collaborator

@eerxuan eerxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a not used error code and feedback in #218 (comment), LGTM.

MAP_MISSING_INPUT_ERROR = 16880
MAP_MISSING_IN_ERROR = 16882
MAP_INPUT_NOT_ARRAY_ERROR = 16883
LEGACY_MIN_DISTANCE_NOT_NUMBER_ERROR = 16893
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants