Skip to content

Add $addToSet accumulator tests#239

Merged
eerxuan merged 17 commits into
documentdb:mainfrom
alinaliBQ:addToSet
May 29, 2026
Merged

Add $addToSet accumulator tests#239
eerxuan merged 17 commits into
documentdb:mainfrom
alinaliBQ:addToSet

Conversation

@alinaliBQ
Copy link
Copy Markdown
Contributor

This change adds tests for the $addToSet accumulator operator.

Add accumulator operator tests for $addToSet. Tests database $addToSet behavior, output collection, syntax, and expected errors.
Integration tests are in documentdb_tests/compatibility/tests/core/operator/accumulators/test_accumulators_ addToSet_integration.py

@alinaliBQ alinaliBQ marked this pull request as ready for review May 25, 2026 23:14
@alinaliBQ alinaliBQ requested a review from a team as a code owner May 25, 2026 23:14
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels May 25, 2026
@documentdb-triage-tool
Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.92 (mixed)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (1868+0 LOC, 10 files); LLM: Adds new integration test coverage for the $addToSet accumulator operator under the compatibility tests path, expanding functional test coverage for a core operator.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

alinaliBQ added 12 commits May 26, 2026 14:30
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Add tests: arity error tests, BSON constant tests, expression tests, order dependence tests. Removed  tests.

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
Copy link
Copy Markdown
Contributor Author

applied #214 (review): Add tests: arity error tests, BSON constant tests, expression tests, order dependence tests. Removed Code tests.

Copy link
Copy Markdown
Collaborator

@eerxuan eerxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use framework.test_constants (FLOAT_NAN, DECIMAL128_INFINITY, etc.) for consistency with sibling tests.

alinaliBQ added 3 commits May 28, 2026 15:30
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Removed duplicate test as well

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Copy link
Copy Markdown
Contributor Author

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments

@eerxuan eerxuan merged commit 14c899a into documentdb:main May 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants