Skip to content

Add $concatArrays accumulator tests#243

Open
alinaliBQ wants to merge 10 commits into
documentdb:mainfrom
alinaliBQ:concatArrays
Open

Add $concatArrays accumulator tests#243
alinaliBQ wants to merge 10 commits into
documentdb:mainfrom
alinaliBQ:concatArrays

Conversation

@alinaliBQ
Copy link
Copy Markdown
Contributor

This change adds tests for the $concatArrays accumulator operator.

Add accumulator operator tests for $concatArrays. Tests database $concatArrays behavior, output collection, syntax, and expected errors.
Integration tests are in documentdb_tests/compatibility/tests/core/operator/accumulators/test_accumulators_ concatArrays_integration.py

@alinaliBQ alinaliBQ marked this pull request as ready for review May 26, 2026 22:21
@alinaliBQ alinaliBQ requested a review from a team as a code owner May 26, 2026 22:21
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels May 26, 2026
@documentdb-triage-tool
Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.90 (mixed)

Reasoning

component from path globs (test-coverage); effort from diff stats (1155+0 LOC, 5 files); LLM: Adds new integration test coverage for the $concatArrays accumulator operator under the compatibility tests path, a meaningful but self-contained test expansion.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

alinaliBQ added 9 commits May 26, 2026 16:41
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
…expression error propagation tests, order dependence tests. Removed tests.

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
Copy link
Copy Markdown
Contributor Author

applied #214 (review): Add tests: arity error tests, BSON constant tests, expression tests, expression error propagation tests, order dependence tests. Removed Code tests.

{
"$group": {
"_id": None,
"result": {"$concatArrays": {"$divide": ["$v", 0]}},
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests:
{"$divide": [1, "$v"]} with docs=[{"v": 0}].

and test if docs before last can trigger it. docs=[{"v": 1}, {"v": 0}]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants