Skip to content

Feature/dpr/feature development#141

Merged
dploeger merged 9 commits intodevelopfrom
feature/dpr/feature-development
Jun 26, 2024
Merged

Feature/dpr/feature development#141
dploeger merged 9 commits intodevelopfrom
feature/dpr/feature-development

Conversation

@dploeger
Copy link
Copy Markdown
Member

Optimized documentation and feature utils

Added template for new features

@dploeger dploeger self-assigned this Apr 17, 2024
@dploeger dploeger requested a review from a team as a code owner April 17, 2024 11:01
@dploeger dploeger marked this pull request as draft April 17, 2024 11:20
@dploeger dploeger marked this pull request as ready for review April 17, 2024 13:09
Copy link
Copy Markdown
Member

@timdeluxe timdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho the template for features should not include direnv, please replace it with a placeholder.
also i think it is wrong to have the template as "normal" feature in the readme.md

@dploeger
Copy link
Copy Markdown
Member Author

Imho the template for features should not include direnv, please replace it with a placeholder. also i think it is wrong to have the template as "normal" feature in the readme.md

Oh my, that' basically a copy and paste error. 😆 Will do.

@dploeger
Copy link
Copy Markdown
Member Author

Also, I'll remove the template from the doc generation tool. That makes no sense.

@dploeger
Copy link
Copy Markdown
Member Author

@timdeluxe fixed both

@dploeger dploeger requested a review from timdeluxe April 18, 2024 06:52
Copy link
Copy Markdown
Member

@timdeluxe timdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎁

Comment thread README.md.gotmpl Outdated
Comment thread assets/feature-installer-utils.sh Outdated
Comment thread assets/feature-installer-utils.sh
Comment thread feature/.template/install.sh
Comment thread assets/feature-installer-utils.sh
@dploeger dploeger requested review from ThomasMinor and removed request for rexhinvorpsi April 18, 2024 08:15
Comment thread README.md Outdated
@dploeger dploeger mentioned this pull request Jun 26, 2024
@dploeger dploeger merged commit 25c0841 into develop Jun 26, 2024
@dploeger dploeger deleted the feature/dpr/feature-development branch August 5, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants