Skip to content

Fix false "New Update Available" notifications on latest releases#90

Merged
dodoflix merged 2 commits intodevelopfrom
copilot/fix-false-update-notifications
Mar 15, 2026
Merged

Fix false "New Update Available" notifications on latest releases#90
dodoflix merged 2 commits intodevelopfrom
copilot/fix-false-update-notifications

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 15, 2026

The compiled .jar contains the old version from gradle.properties because version bumping happens in the release job after the build job. The file gets renamed to the new version for publishing, but UpdateChecker still sees the old internal version and falsely warns users to update.

Changes to .github/workflows/auto-release.yml

  • Move version calculation before build: Extracted release_type, current_version, bump, and new_version steps from the release job into the check-changes job. Exported new_version and is_production as job outputs.
  • Inject version at compile time: Pass calculated version to Gradle via -PmodVersion= flag:
    - name: Build all platforms
      run: ./gradlew build --no-daemon -PmodVersion=${{ needs.check-changes.outputs.new_version }}
  • Update release job: Replace all steps.new_version.outputs.* and steps.release_type.outputs.* references with needs.check-changes.outputs.*; remove the now-redundant calculation steps.
  • Bump fetch-depth to 0 in check-changes (full history needed for tag listing and commit analysis).

No changes to build.gradle.kts — Gradle's -P flag natively overrides properties from gradle.properties.


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

…ions

Move version calculation (release_type, current_version, bump, new_version)
from the release job to the check-changes job so the new version is known
before compilation. Pass the calculated version to Gradle via -PmodVersion
flag, ensuring the internal version in compiled .jar files matches the
release version published to GitHub and Modrinth.

This fixes the false "new update available" notifications that occurred
because artifacts were compiled with the old version from gradle.properties
but published under the new bumped version.

Co-authored-by: dodoflix <43419555+dodoflix@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix false 'New update available' notifications on latest releases Fix false "New Update Available" notifications on latest releases Mar 15, 2026
Copilot AI requested a review from dodoflix March 15, 2026 14:58
@dodoflix dodoflix marked this pull request as ready for review March 15, 2026 15:04
@dodoflix dodoflix merged commit 60463a0 into develop Mar 15, 2026
9 checks passed
Copilot AI added a commit that referenced this pull request Mar 15, 2026
…rge)

Co-authored-by: dodoflix <43419555+dodoflix@users.noreply.github.com>
@dodoflix dodoflix deleted the copilot/fix-false-update-notifications branch March 15, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants