ci(workflows): wire GitHub Actions env vars + secrets — FR-005 #19#21
Merged
dogkeeper886 merged 2 commits intotestlink_1_9_20_fixedfrom Apr 20, 2026
Merged
Conversation
Run-tests step now exports LLM_JUDGE_URL, LLM_JUDGE_MODEL, and TL_DEV_KEY from repo secrets/vars into the job environment. When unset, the framework's existing defaults apply — simple-judge CI runs unchanged, local dev via cicd/tests/.env unaffected. Adds cicd/CI_SETUP.md naming the secrets/variables a collaborator must add in their fork's Settings → Secrets and variables → Actions. Marks FR-005 in-progress in its frontmatter and the index. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…MODEL
Two issues the initial FR-005 wiring missed, plus a default refresh:
1. test-pipeline.yml invokes test-suite.yml via workflow_call. Without
`secrets: inherit`, secrets defined in repo settings don't cross the
reusable-workflow boundary, so ${{ secrets.LLM_JUDGE_URL }} evaluated
to "" when the pipeline was run as the main entry point. Fix by
adding `secrets: inherit` to all five job calls. Direct
workflow_dispatch of test-suite.yml already worked.
2. test-suite.yml's `judge_model` input defaulted to 'llama3:8b' and
was always passed via --judge-model on the CLI. That shadowed
LLM_JUDGE_MODEL from the env block (fed by vars.LLM_JUDGE_MODEL),
making the repo variable dead-lettered. Fix by defaulting the
input to empty and only appending --judge-model when the operator
explicitly typed one — otherwise the env var / framework default
take effect. Precedence is now: CLI flag (explicit) > env var
(repo variable) > config.ts default.
3. Framework default model flips from llama3:8b to gemma3:4b (smaller,
faster, what the project actually targets). Updated in config.ts,
types.ts, CI_SETUP.md, and FR-005.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements FR-005. Closes #19.
Summary
test-suite.ymlexportsLLM_JUDGE_URL,LLM_JUDGE_MODEL,TL_DEV_KEYfrom repo secrets/vars into the run step's env. Local dev viacicd/tests/.envis unaffected — the runner never materializes that file.test-pipeline.ymlgetssecrets: inheriton all five job calls so secrets cross theworkflow_callboundary when the pipeline is the entry point.--judge-modelis only appended when the operator explicitly typed one at dispatch time, sovars.LLM_JUDGE_MODEL/ the framework default aren't shadowed. Precedence: CLI flag (explicit) > env var (repo variable) >config.tsdefault.llama3:8btogemma3:4binconfig.ts,types.ts,CI_SETUP.md, and FR-005.cicd/CI_SETUP.mdnaming the secrets/variables a collaborator adds in fork settings.Why two commits
The first commit (
883ab49f) plumbs the env block and writes the doc. Review turned up two non-obvious bugs —secrets: inheritmissing on the pipeline caller, andLLM_JUDGE_MODELbeing shadowed by the always-present--judge-modelCLI flag. The second commit (17fae8fb) fixes both and refreshes the default model. Kept as separate commits to make the second one's reasoning self-documenting.Test plan
test-suite.ymldirectly withjudge_mode=simple, confirm green run with--no-llmtest-pipeline.ymlwithjudge_mode=simple, confirm all five suites greensecrets.LLM_JUDGE_URL+vars.LLM_JUDGE_MODELset in fork settings, dispatchtest-pipeline.ymlwithjudge_mode=dual, confirm LLM judge reaches the configured endpoint and uses the configured model (notgemma3:4bframework default, notllama3:8b)bash cicd/scripts/run-tests.sh --suite smokestill works againstcicd/tests/.env🤖 Generated with Claude Code