Skip to content

Conversation

@janbruedigam
Copy link
Member

No description provided.

@janbruedigam janbruedigam changed the title Compat for 1 7 Compat for Julia 1.7 and switch from Roations.jl to Quaternions.jl Mar 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #10 (ba08bb7) into main (efab5f2) will increase coverage by 0.01%.
The diff coverage is 88.29%.

❗ Current head ba08bb7 differs from pull request most recent head 8ef741e. Consider uploading reports for the commit 8ef741e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   92.13%   92.14%   +0.01%     
==========================================
  Files          81       81              
  Lines        3816     3821       +5     
==========================================
+ Hits         3516     3521       +5     
  Misses        300      300              
Impacted Files Coverage Δ
src/Dojo.jl 100.00% <ø> (ø)
src/bodies/set.jl 94.91% <ø> (ø)
src/contacts/nonlinear.jl 100.00% <ø> (ø)
src/contacts/utilities.jl 0.00% <ø> (ø)
src/joints/impulses.jl 100.00% <ø> (ø)
src/joints/joint.jl 89.39% <ø> (ø)
src/joints/limits.jl 100.00% <ø> (ø)
src/joints/rotational/constructor.jl 100.00% <ø> (ø)
src/joints/rotational/impulses.jl 100.00% <ø> (ø)
src/joints/rotational/input.jl 43.58% <ø> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efab5f2...8ef741e. Read the comment docs.

@thowell
Copy link
Member

thowell commented Mar 10, 2022

Is it possible to remove dependency on Rotations? What are the benefits to using Quaternions.jl over the implementation in Rotations.jl?

@janbruedigam
Copy link
Member Author

Completely removing the dependency on Rotations.jl is possible and requires rewriting just a few small functions (rand, or some mappings for MeshCat/CoordinateTransformations). So yes, makes sense!
The issue with the new Rotations.jl versions is that a QuatRotation needs to be unit length, and is changed to a Quaternion when it is no longer unit length. We are doing a lot of multiplications of quaternions with scalars, for example for angular velocities, which no longer gives us a unit length quaternion and would require adding a number of functions / special casing.

@janbruedigam janbruedigam merged commit d72135e into main Mar 10, 2022
@janbruedigam janbruedigam deleted the compat_for_1_7 branch March 10, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants