Updates to Defining an Environment #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visualization was causing the following: ERROR: LoadError: UndefVarError: Visualizer not defined I moved it to after the dependencies are loaded
Added the DojoEnvironments.visualize. I don't think that visualize is exported from DojoEnvironments and was causing errors.
The P gain and the simulation time needed to be increased to match the desired performance.
NOTE:
```
storage = simulate!(mechanism, 20.0, controller!,
record=true,
verbose=true);
```
This outputs NAN values for mu
Quad example
Updated the gain and simulation time
Added necessary packages, fixed variable name mismatches, and other small bug fixes for a working example.
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
===========================================
- Coverage 87.67% 48.12% -39.56%
===========================================
Files 94 94
Lines 4966 4958 -8
===========================================
- Hits 4354 2386 -1968
- Misses 612 2572 +1960
Continue to review full report at Codecov.
|
rejuvyesh
reviewed
Jul 26, 2022
docs/src/define_environment.md
Outdated
| For this example we need the following setup: | ||
| ```julia | ||
| using Pkg | ||
| Pkg.activate(joinpath(@__DIR__, "..")) |
Contributor
There was a problem hiding this comment.
These should not be necessary, and if they are we need to fix those.
Collaborator
Author
There was a problem hiding this comment.
You are correct it was not necessary. I will remove that.
addressing comment from pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code and documentation for Defining an Environment example.
This included adding necessary packages, defining variables and consistent variable names.
Now ant environment example works by blindly copy and pasting all lines to new julia script.