Skip to content

Adding support for custom element transformer#53

Merged
rorticus merged 9 commits intodojo:masterfrom
rorticus:element-transform
Jun 7, 2019
Merged

Adding support for custom element transformer#53
rorticus merged 9 commits intodojo:masterfrom
rorticus:element-transform

Conversation

@rorticus
Copy link
Copy Markdown
Contributor

@rorticus rorticus commented Mar 22, 2019

Adding support for the new custom element transformer.

Notable changes:

  • Upgrading to @dojo/framework 6.0.0-alpha to get changes to registerCustomElement
  • Upgrading ts-loader because we need at least 5.3.3 (includes support for sending program instance to custom transformers)
  • Turning off onlyCompileBundledFiles so that all type information is sent to custom transformers.
  • Removed test files from test-app/ that weren't being used
  • Removed @customElement decorators from test-app/ widgets, relying on new custom element transformer instead.

Relates to: dojo/webpack-contrib#43

@rorticus rorticus requested a review from agubler March 22, 2019 16:36
Comment thread package.json Outdated
"strip-ansi": "4.0.0",
"terser-webpack-plugin": "1.1.0",
"ts-loader": "5.3.0",
"ts-loader": "^5.3.3",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump ts-loader. 5.3.3 makes the typescript program available to the transformers.

Comment thread src/base.config.ts
@rorticus
Copy link
Copy Markdown
Contributor Author

Note that CI isn't going to pass as it's dependent on dojo/webpack-contrib#133

@rorticus rorticus force-pushed the element-transform branch from 0075314 to 3d459d5 Compare May 17, 2019 13:29
@codecov
Copy link
Copy Markdown

codecov bot commented May 17, 2019

Codecov Report

Merging #53 into master will decrease coverage by 0.71%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage    71.3%   70.58%   -0.72%     
==========================================
  Files           8        8              
  Lines         352      357       +5     
  Branches       59       60       +1     
==========================================
+ Hits          251      252       +1     
- Misses        101      105       +4
Impacted Files Coverage Δ
src/base.config.ts 33.82% <20%> (-1.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cea44...512334e. Read the comment docs.

@rorticus rorticus requested a review from matt-gadd May 17, 2019 13:43
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 3, 2019

Codecov Report

Merging #53 into master will decrease coverage by 0.63%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage    71.3%   70.67%   -0.64%     
==========================================
  Files           8        8              
  Lines         352      358       +6     
  Branches       59       59              
==========================================
+ Hits          251      253       +2     
- Misses        101      105       +4
Impacted Files Coverage Δ
src/main.ts 95.27% <100%> (+0.03%) ⬆️
src/base.config.ts 33.82% <20%> (-1.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cea44...ff2ab89. Read the comment docs.

@rorticus rorticus merged commit 8e92ba5 into dojo:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants