Skip to content

fixed comment at method has()#124

Closed
jonatahr wants to merge 1 commit into
dojo:masterfrom
jonatahr:master
Closed

fixed comment at method has()#124
jonatahr wants to merge 1 commit into
dojo:masterfrom
jonatahr:master

Conversation

@jonatahr
Copy link
Copy Markdown
Contributor

Type: bug

The following has been addressed in the PR:

Description:
Fixed comment at method has(), the comment before suggests that param can be integer and string, but type is string.

Resolves #84

@jsf-clabot
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jonatah Braz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@jonatahr
Copy link
Copy Markdown
Contributor Author

Well, I already signed to CLA, I don't know why it's still showing "pending".

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 21, 2018

Codecov Report

Merging #124 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files          93       93           
  Lines        4959     4959           
  Branches     1088     1088           
=======================================
  Hits         4813     4813           
  Misses        146      146
Impacted Files Coverage Δ
src/has/has.ts 98.64% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ecb636...fac9936. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants