Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dojo/dojowidgets/h1rru3bky |
Codecov Report
@@ Coverage Diff @@
## master #1494 +/- ##
==========================================
- Coverage 91.06% 90.93% -0.14%
==========================================
Files 84 85 +1
Lines 4242 4278 +36
Branches 1145 1153 +8
==========================================
+ Hits 3863 3890 +27
- Misses 180 184 +4
- Partials 199 204 +5
Continue to review full report at Codecov.
|
|
@maier49 this seems a bit intrusive on widget authoring. I couldn't really tell how a user would pass a resource template from html either? is this something we can potentially solve at the framework/element wrapper level without a wrapping widget? |
|
Closing in favor of attempting to resolve this directly in framework |
Type: bug
The following has been addressed in the PR:
.dojorctheme.variant()is added to the root domnodetheme.composelike thisDescription:
Adds a
Resourcewidget which is intended to be used only as a custom element to wrap widgets that expect a resource. It can be seen in action here wrapping a list component:https://resource-widget.vercel.app/
The changes to other widgets were needed because when rendering as a custom element the child widget renders once before the parent can edit its properties, which was accessing an undefined object in widgets that use a resource.
Resolves #1481