fix(dojo-core): remove unsupported syscall

[glihm]

Starknet 0.13.4 will be released in testnet in late February and mainnet in late March. To avoid waiting this time to deploy dojo worlds on public network, the dns is not using anymore the get_class_hash_at syscall.

Currently the dns is mostly used for the ContractAddress, and not the class hash. Which shouldn't impact current usage.

Summary by CodeRabbit

• Bug Fixes
  • Temporarily modified DNS-related test and storage retrieval to use a zero value instead of a specific class hash
  • Added a comment indicating the change is temporary until Starknet version 0.13.4 is released

[coderabbitai]

Walkthrough

Ohayo, sensei! The changes involve modifications to the DNS (Domain Name System) related functionality in the Dojo project. In the test file and core storage implementation, the code now uses a placeholder zero value for class hash retrieval instead of the actual syscall. This appears to be a temporary adjustment, with a comment suggesting a reversion once Starknet version 0.13.4 is released.

Changes

File	Change Summary
crates/dojo/core-cairo-test/src/tests/world/world.cairo	Modified dns_valid_class_hash test to assert against 0.try_into().unwrap() instead of bar::TEST_CLASS_HASH
crates/dojo/core/src/world/storage.cairo	Commented out get_class_hash_at_syscall in dns_from_selector function, now returning a static 0.try_into().unwrap()

Possibly related PRs

• fix(dojo-lang): ensure the dns returns the actual ClassHash. #2935: Test function for class hash association, directly related to DNS functionality changes
• docs: fix typo (n-06) #2641: Involves upgrade method and contract interactions
• fix(dojo-core): adjust ACL to restore governance without relaxing permissions #2341: Modifications to test functions in world.cairo

Suggested labels

audit

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd7e42d and aac5ef4.

⛔ Files ignored due to path filters (6)

• crates/dojo/core-cairo-test/Scarb.lock is excluded by !**/*.lock
• crates/torii/types-test/Scarb.lock is excluded by !**/*.lock
• examples/simple/Scarb.lock is excluded by !**/*.lock
• examples/spawn-and-move/Scarb.lock is excluded by !**/*.lock
• spawn-and-move-db.tar.gz is excluded by !**/*.gz
• types-test-db.tar.gz is excluded by !**/*.gz

📒 Files selected for processing (2)

• crates/dojo/core-cairo-test/src/tests/world/world.cairo (1 hunks)
• crates/dojo/core/src/world/storage.cairo (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: docs
• GitHub Check: ensure-wasm
• GitHub Check: build

🔇 Additional comments (2)

crates/dojo/core/src/world/storage.cairo (1)

75-78: Ohayo, sensei! LGTM - Temporary workaround looks good.

The temporary removal of get_class_hash_at_syscall and replacement with a zero value is a pragmatic solution until Starknet v0.13.4 is released. The TODO comment clearly indicates this is temporary.

Let's verify if there are any other usages of this syscall in the codebase:

✅ Verification successful

Ohayo, sensei! Syscall usage verification complete - all clear!

The search confirms that this is the only instance of get_class_hash_at_syscall in the codebase, and it's already properly commented out. The temporary workaround is consistently applied.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining instances of the syscall
rg "get_class_hash_at_syscall"

Length of output: 171

crates/dojo/core-cairo-test/src/tests/world/world.cairo (1)

330-332: Ohayo again, sensei! Test adjustment looks good.

The test has been correctly updated to match the temporary zero value implementation, with a clear TODO comment for restoring the original assertion once Starknet v0.13.4 is released.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.70%. Comparing base (dd7e42d) to head (aac5ef4).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2962      +/-   ##
==========================================
- Coverage   56.71%   56.70%   -0.02%     
==========================================
  Files         420      420              
  Lines       55557    55557              
==========================================
- Hits        31507    31501       -6     
- Misses      24050    24056       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.