Skip to content

fix(pipeline): don't restart run_loop future on tip change#368

Merged
kariy merged 3 commits intomainfrom
fix/pipeline-run
Nov 24, 2025
Merged

fix(pipeline): don't restart run_loop future on tip change#368
kariy merged 3 commits intomainfrom
fix/pipeline-run

Conversation

@kariy
Copy link
Member

@kariy kariy commented Nov 24, 2025

Currently the select! is configured in Pipeline::run to completes on the command waiting regardless of what command is received. This means the self.run_loop() future will be cancelled even if it's a command for changing the pipeline's tip - the pipeline has to process the same batch again.

@kariy kariy changed the title fix(pipeline): don't restart run_loop future on tip change fix(pipeline): don't restart run_loop future on tip change Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.33%. Comparing base (9bde0ae) to head (237ef33).
⚠️ Report is 190 commits behind head on main.

Files with missing lines Patch % Lines
crates/sync/pipeline/src/lib.rs 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main     #368     +/-   ##
=========================================
  Coverage   73.32%   73.33%             
=========================================
  Files         209      256     +47     
  Lines       23132    32324   +9192     
=========================================
+ Hits        16961    23704   +6743     
- Misses       6171     8620   +2449     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kariy kariy merged commit 28565d7 into main Nov 24, 2025
11 checks passed
@kariy kariy deleted the fix/pipeline-run branch November 24, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant