fix(ci): install cargo-release with +stable toolchain#430
Merged
Conversation
The repo's rust-toolchain.toml pins 1.90.0, which overrides the workflow's stable setup during cargo install. cargo-release 1.1.2 requires rustc 1.91, so the install fails. Use +stable to compile the helper CLIs against the latest toolchain regardless of the repo override. Same fix applied to cargo-get to prevent future drift. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
release-dispatchworkflow'scargo install cargo-release --lockedstep fails because the repo'srust-toolchain.tomlpins 1.90.0, which overrides the workflow'sstabletoolchain setup. The latestcargo-release(1.1.2) requires rustc 1.91+, so the build aborts:(Failed run: https://github.com/dojoengine/torii/actions/runs/26179260967)
Fix
Use
cargo +stable installfor both helper CLIs (cargo-release,cargo-get). These tools don't compile this repo — they just consume/editCargo.toml— so there's no reason to honor the repo's pinned toolchain when building them.+stablesidesteps the override without touchingrust-toolchain.toml. Applied tocargo-getproactively so the next MSRV bump doesn't break it the same way.